Cleanup ruby code via rubocop #85
Conversation
willmeek
requested review from
pmcmaw,
david22swan,
davidmalloncares and
davinhanlon
spec/spec_helper.rb
Outdated
| @@ -13,4 +13,5 @@ | |||
| begin | |||
| require 'spec_helper_local' | |||
| rescue LoadError | |||
| puts 'LoadError rescue' | |||
There was a problem hiding this comment.
it'd be good to have something more informative here. maybe something like this?
begin
require 'spec_helper_local'
rescue LoadError => loaderror
puts "Could not require spec_helper_local: #{loaderror.message}"
endThere was a problem hiding this comment.
Great suggestion Eric, thanks, have added this.
spec/acceptance/nodesets/default.yml
Outdated
| @@ -1,17 +1,31 @@ | |||
| --- | |||
| HOSTS: | |||
| windows2012-64-1: | |||
There was a problem hiding this comment.
modulesync is going to change this back to windows2012 because this module is now marked as cross-platform. getting around it might be hairy...
There was a problem hiding this comment.
Thanks Eric, have reverted this.
willmeek
force-pushed
the
rubocopification
branch
from
54ae776
to
7823030
Compare
| .travis.yml: | ||
| extras: | ||
| - rvm: 2.1.9 | ||
| script: bundle exec rake rubocop |
There was a problem hiding this comment.
Can you remove this line break?
There was a problem hiding this comment.
There wasn't a line break. I've added one as it seems that the github diff was highlighting this as an issue?
There was a problem hiding this comment.
Hmm strange, when I commented there was a small red arrow at the end of the line. Anyway looks good to me.
There was a problem hiding this comment.
No no, you're right, there was, adding a line break got rid of it :)
This commit will add code cleanup as corrected and alerted by rubocop. It also adds rules to execute rubocop on Travis.
willmeek
force-pushed
the
rubocopification
branch
from
7823030
to
5e6a0ee
Compare
This commit will add code cleanup as corrected
and alerted by rubocop. It also adds rules to
execute rubocop on Travis.