-
Notifications
You must be signed in to change notification settings - Fork 108
we want to use vmware fusion and virtualbox as a vagrant provider #199
Conversation
mmailand
commented
Jun 5, 2015
* 05_up.sh detects installed provider and defaults vmware_fusion * Vagrantfile add nic, memory and vcpu customizations for virtualbox * examples/common.yaml change openstack:nova:libvirt_type to qemu
exit 1 | ||
fi | ||
} # ---------- end of function provider ---------- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The provider() function doesn't use the $PROVIDER variable that you set above. Shouldn't it try to use $PROVIDER first if it is set by the user?
@saneax could you take a look too, since you were working on something similar? |
@@ -132,7 +132,7 @@ openstack::swift::hash_suffix: 'pop-bang' | |||
|
|||
######## Nova | |||
|
|||
openstack::nova::libvirt_type: 'kvm' | |||
openstack::nova::libvirt_type: 'qemu' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change needs to be made in examples/allinone.yaml as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greetings,
I will take this up.
One question although, should this work go into puppetlabs/openstack or
stackforge/openstack.
Being new I am still a bit confused on that.
regards
/sanjay
On Wed, Jun 10, 2015 at 3:17 AM, Colleen Murphy notifications@github.com
wrote:
In examples/common.yaml
#199 (comment)
:@@ -132,7 +132,7 @@ openstack::swift::hash_suffix: 'pop-bang'
######## Nova
-openstack::nova::libvirt_type: 'kvm'
+openstack::nova::libvirt_type: 'qemu'This change needs to be made in examples/allinone.yaml as well
—
Reply to this email directly or view it on GitHub
https://github.com/puppetlabs/puppetlabs-openstack/pull/199/files#r32068357
.
Sanjay Upadhyay
http://saneax.blogspot.com
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The puppet-openstack module on stackforge is deprecated.
There is also stackforge/puppet-openstack-cloud but it does not have any vagrant examples so this change would not be applicable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Colleen for the clarification, I will work on this and resubmit the
patch in a week.
I hope that's an acceptable timeline :)
Moreover, I would like some mentoring so I will seek help on IRC.
regards
/sanjay
On Thu, Jun 11, 2015 at 7:15 AM, Colleen Murphy notifications@github.com
wrote:
In examples/common.yaml
#199 (comment)
:@@ -132,7 +132,7 @@ openstack::swift::hash_suffix: 'pop-bang'
######## Nova
-openstack::nova::libvirt_type: 'kvm'
+openstack::nova::libvirt_type: 'qemu'The puppet-openstack module on stackforge is deprecated.
There is also stackforge/puppet-openstack-cloud but it does not have any
vagrant examples so this change would not be applicable.—
Reply to this email directly or view it on GitHub
https://github.com/puppetlabs/puppetlabs-openstack/pull/199/files#r32183988
.
Sanjay Upadhyay
http://saneax.blogspot.com
Any update on this? |
@cmurphy I could push a new branch with fixed the issue with checking the env for the provider type and with fixed whitespacing, would that be okay? |
@mmailand plese do, thanks! |
Folks, sorry not to update so far, Will try to get this completed over the warm regards On Thu, Jul 16, 2015 at 6:46 AM, Colleen Murphy notifications@github.com
Sanjay Upadhyay |