Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(SUP-3005) Update plan output format #117

Merged
merged 2 commits into from
Apr 20, 2022

Conversation

jarretlavallee
Copy link
Contributor

This commit changes the output of the plan format to have a summary and
details. It aligns the parameters with the init.pp class to ensure that
the plan can handle excluding checks.

Output examples:

{
    "nodes": {
        "details": {
            "puppet.example.com": {
                "Failed Test Count": 0,
                "Failed Test Details": [],
                "Passing Tests Count": 28
            }
        },
        "failing": [],
        "passing": [
            "puppet.example.com"
        ]
    },
    "errors": {
        "agent.example.com": "Missing the 'pe_status_check' fact"
    },
    "passed": false,
    "failing_node_count": 1,
    "passing_node_count": 1
}
{
  "nodes": {
      "details": {
          "puppet.example.com": {
              "Failed Test Count": 0,
              "Failed Test Details": [],
              "Passing Tests Count": 28
          }
      },
      "failing": [],
      "passing": [
          "puppet.example.com"
      ]
  },
  "errors": {},
  "passed": true,
  "failing_node_count": 0,
  "passing_node_count": 1
}

@jarretlavallee jarretlavallee requested a review from a team as a code owner April 20, 2022 13:38
This commit changes the output of the plan format to have a summary and
details. It aligns the parameters with the init.pp class to ensure that
the plan can handle excluding checks.
Prior to this commit, it was required to specify a target list to the
plan of the nodes to check. This commit changes the default of the
targets parameter to use a PuppetDB lookup to identify the nodes with
the `pe_build` fact as the target list. After this change, it is easier
to run the plan on all infrastructure nodes when bolt is configured to
connect to PuppetDB.
@jarretlavallee jarretlavallee merged commit 3ae7917 into puppetlabs:main Apr 20, 2022
@jarretlavallee jarretlavallee deleted the plan_updates branch April 20, 2022 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants