Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgresql::params does not have a valid default value for $service_status on ArchLinux #1408

Closed
Phil-Friderici opened this issue Mar 23, 2023 · 0 comments · Fixed by #1410
Closed

postgresql::params does not have a valid default value for $service_status on ArchLinux #1408

Phil-Friderici opened this issue Mar 23, 2023 · 0 comments · Fixed by #1410
Labels
community

Comments

@Phil-Friderici
Copy link

Describe the Bug

On ArchLinux $service_status isn't defined and the module fails hard.
Error message:
Evaluation Error: Error while evaluating a Resource Statement, Postgresql::Server::Instance::Reload[main]: parameter 'service_status' expects a String value, got Undef

Expected Behavior

$service_status should provide a valid value for ArchLinux out of the box.

Steps to Reproduce

On ArchLinux:
include postgresql::server

Additional Context

A quick fix could be to change the value for $service_status (line 138 in params.pp) to "systemctl status ${service_name}"
@Phil-Friderici Phil-Friderici mentioned this issue Mar 23, 2023
Merged
smortex added a commit that referenced this issue Mar 27, 2023
@smortex
Fix default value for $service_status on ArchLinux
9ca4d36 
The value can be overriden from `postgresql::globals`, but if no
override is provided by the user, the module should use a valid default.
ArchLinux use systemd, so use the relevant `systemctl` command.

Fixes #1408
@smortex smortex mentioned this issue Mar 27, 2023
Merged
This was referenced Mar 29, 2023
Closed
Merged
smortex added a commit that referenced this issue Mar 31, 2023
@smortex
Fix default value for $service_status on ArchLinux
bd412ea 
The value can be overriden from `postgresql::globals`, but if no
override is provided by the user, the module should use a valid default.
ArchLinux use systemd, so use the relevant `systemctl` command.

Fixes #1408
bastelfreak pushed a commit that referenced this issue Jun 30, 2023
@smortex @bastelfreak
Fix default value for $service_status on ArchLinux
fa9a21c 
The value can be overriden from `postgresql::globals`, but if no
override is provided by the user, the module should use a valid default.
ArchLinux use systemd, so use the relevant `systemctl` command.

Fixes #1408
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix default value for $service_status on ArchLinux puppetlabs/puppetlabs-postgresql
2 participants
@Phil-Friderici @ia-content