Clean up globals logic to support CentOS 8 stream

[ekohl]

This is a code simplification for distributions that don't change the
PostgreSQL version in a major release. As a bonus fact, it adds support for
CentOS 8 Stream which identifies itself without a minor version.

For completeness, the OS facts from CentOS 8 Stream:

# facter os
{
  architecture => "x86_64",
  family => "RedHat",
  hardware => "x86_64",
  name => "CentOS",
  release => {
    full => "8",
    major => "8"
  },
  selinux => {
    enabled => false
  }
}

This is an alternative to #1222.

[puppet-community-rangefinder]

postgresql::globals is a class

Breaking changes to this file WILL impact these 20 modules (exact match):

• nicopaez-dockerserver
• jmkeyes-razor
• landcareresearch-pidservice
• nnutter-testdb
• landcareresearch-postgis
• chedi-django
• nicopaez-alfred
• nicopaez-triage
• lwo-dataverse
• tailoredautomation-patroni
• mukaibot-bamboo
• stackstorm-st2
• maestrodev-maestro
• it2ndq-barman
• deric-barman
• npwalker-pe_external_postgresql
• puppetlabs-puppetdb
• SchnWalter-happydev
• groupbuddies-gb
• conzar-pidservice

Breaking changes to this file MAY impact these 2 modules (near match):

• jmkeyes-netbox
• ash-netbox

This module is declared in 70 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[codecov-io]

Codecov Report

Merging #1225 (3eb6299) into main (08e3a51) will increase coverage by 0.37%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main    #1225      +/-   ##
==========================================
+ Coverage   65.81%   66.18%   +0.37%     
==========================================
  Files          14       14              
  Lines         351      349       -2     
==========================================
  Hits          231      231              
+ Misses        120      118       -2     

Impacted Files	Coverage Δ
...ns/postgresql/postgresql_acls_to_resources_hash.rb	0.00% <0.00%> (ø)
...b/puppet/functions/postgresql/postgresql_escape.rb	0.00% <0.00%> (ø)
lib/puppet/util/postgresql_validator.rb	90.90% <0.00%> (ø)
lib/puppet/type/postgresql_psql.rb	90.14% <66.66%> (ø)
...uppet/provider/postgresql_replication_slot/ruby.rb	75.86% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6e875...3eb6299. Read the comment docs.

[sheenaajay]

Thanks @ekohl for your contribution as always.
Could you please take a look at unit tests which are failing with the second commit.

[ekohl]

Looks like I need to do a bit more.

[ekohl]

I went through all files that used the full version. Also went through tests. It's confusing that this module places the files in spec/unit/defines rather than spec/defines as is the convention.

[ekohl]

💚 now

[sheenaajay]

Thank you @ekohl for the fixes.

[ekohl]

@sheenaajay anything holding back a merge? I hope to see this in a released version soon.

[sheenaajay]

@ekohl Sorry for the delay. Next one on the list :-) . We have a release coming soon for a bug fix and can get this also included. Thank you.