Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNF module management #1239

Merged
merged 1 commit into from Mar 4, 2021
Merged

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Feb 16, 2021

On EL8 and Fedora DNF can manage modules. This is a method of providing multiple versions on the same OS. Only one DNF module can be active at the same time.

@puppet-community-rangefinder
Copy link

postgresql::dnfmodule is a class

that may have no external impact to Forge modules.

postgresql::globals is a class

Breaking changes to this file WILL impact these 20 modules (exact match):
Breaking changes to this file MAY impact these 2 modules (near match):

This module is declared in 70 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

On EL8 and Fedora DNF can manage modules. This is a method of providing
multiple versions on the same OS. Only one DNF module can be active at
the same time.
@ekohl ekohl marked this pull request as ready for review February 23, 2021 10:21
@ekohl ekohl requested a review from a team as a code owner February 23, 2021 10:21
@ekohl
Copy link
Collaborator Author

ekohl commented Feb 23, 2021

I am running this on my own server and there it appears to work well.

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021

CLA assistant check
All committers have signed the CLA.

@Zak-Kent
Copy link

fwiw, when investigating Server-2500 and a workaround which was added for this issue in the PuppetDB and Puppetserver acceptance tests I found this pr. I was able to apply the changes here to my test setup and they resolved this issue we were seeing on RHEL-8. I don't have a good sense of what else might be impacted by these changes but once some flavor of this is merged we should be able to update the puppetlabs-puppetdb module to pick up this fix.

@sheenaajay sheenaajay self-assigned this Mar 4, 2021
@sheenaajay
Copy link
Contributor

Thanks @ekohl for your contribution as always.

@sheenaajay sheenaajay merged commit 1dc0e1c into puppetlabs:main Mar 4, 2021
@ekohl ekohl deleted the manage_dnf_module branch March 4, 2021 09:40
cegeka-jenkins pushed a commit to cegeka/puppet-postgresql that referenced this pull request Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants