Make ::contrib a noop on OSes without a contrib package #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ekohl
reviewed
Nov 1, 2021
There was a problem hiding this comment.
If it's a virtual, I wonder if a solution that also works for Gentoo (which also doesn't have a real package) would be better. Like making contrib_package_name an Optional[String[1]] and if it's undef then don't install it.
I'm not sure that's the best solution either. What are your thoughts on it?
ekohl
requested changes
Nov 1, 2021
carlosduelo
force-pushed
the
postgresql-contrib-is-virtual-package-some-dists
branch
2 times, most recently
from
7e7fc58
to
0e5cb49
Compare
ekohl
changed the title
ekohl
reviewed
Nov 1, 2021
carlosduelo
force-pushed
the
postgresql-contrib-is-virtual-package-some-dists
branch
2 times, most recently
from
f57f823
to
6050cfb
Compare
- In debian families: postgresql-contrib is a virtual package and it is not needed to be installed. - Archlinux does have postgresql-contrib but it isn't maintained - Gentoo provides contrib in the main package Referencies: https://packages.debian.org/bullseye/postgresql-contrib-13 https://packages.ubuntu.com/bionic/postgresql-contrib
carlosduelo
force-pushed
the
postgresql-contrib-is-virtual-package-some-dists
branch
from
6050cfb
to
70a0f3c
Compare
Now the contrib package is not installed in Debian So test must check RedHat for exmaple Gentoo is not failing so raise check should not be done anymore.
carlosduelo
force-pushed
the
postgresql-contrib-is-virtual-package-some-dists
branch
from
70a0f3c
to
f10a335
Compare
ekohl
reviewed
Nov 16, 2021
ekohl
approved these changes
Nov 17, 2021
@ekohl can you help me? I don't know why some of them where canceled :( |
|
Looks like they timed out but I think it's safe to ignore those so I'm going to go ahead and merge this. Thanks @carlosduelo! |
ekohl
changed the title
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Feb 3, 2022
…b-is-virtual-package-some-dists debian package postgresql-contrib virtual package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Debian family provides postgresql-contriub-XY as a virtual package of postgresql-XY.
Not sure if allowing virtual packages here is the best solution 🤔
Referencies:
https://packages.debian.org/bullseye/postgresql-contrib-13
https://packages.ubuntu.com/bionic/postgresql-contrib