Cleanup Systemd drop-in file handling #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postgresql::server::instance::config is a typethat may have no external impact to Forge modules. postgresql::server::instance::systemd is a typethat may have no external impact to Forge modules. This module is declared in 70 of 580 indexed public
|
SimonHoenscheid
commented
Feb 2, 2023
bastelfreak
reviewed
Feb 2, 2023
chelnak
reviewed
Feb 2, 2023
chelnak
suggested changes
Feb 2, 2023
ekohl
reviewed
Feb 2, 2023
bastelfreak
reviewed
Feb 3, 2023
bastelfreak
reviewed
Feb 3, 2023
SimonHoenscheid
force-pushed
the
shoenscheid_systemd_cleanup
branch
4 times, most recently
from
6d6364d
to
548f5b2
Compare
|
@bastelfreak @chelnak @ekohl this is ready for a final review, all previous comments have been addressed |
SimonHoenscheid
requested review from
chelnak,
bastelfreak and
ekohl
and removed request for
chelnak,
bastelfreak and
ekohl
ekohl
reviewed
Feb 13, 2023
SimonHoenscheid
force-pushed
the
shoenscheid_systemd_cleanup
branch
2 times, most recently
from
e3a83ea
to
3261f59
Compare
ekohl
reviewed
Feb 13, 2023
ekohl
reviewed
Feb 13, 2023
SimonHoenscheid
force-pushed
the
shoenscheid_systemd_cleanup
branch
from
3261f59
to
f15dd8b
Compare
* add puppet/systemd module
* remove systemd daemon reload and raise minimal puppet version to 6.1
* remove old "drop-in file" removal, was in place 3 years now
* move systemd drop-in file handling to seperate define
* Implement recent feedback
* define is now private
* rename parameter in define call
* fix unit tests
* fix rubocop complains
* fix path, set default fact
* fix systemd drop in file, adding template parameters to systemd define
* added reason for drop in file in a comment
* added reviewers feedback
* remove ensure parameter for systemd drop-in file handling, except
for the define itself.
* systemd_extra_args expects String, default is undef now
SimonHoenscheid
force-pushed
the
shoenscheid_systemd_cleanup
branch
from
f15dd8b
to
5eb1e8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for the define itself.