add missing parameters to initdb #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastelfreak
reviewed
Jun 27, 2023
bastelfreak
reviewed
Jun 27, 2023
bastelfreak
reviewed
Jun 27, 2023
SimonHoenscheid
force-pushed
the
initdb_parameters
branch
2 times, most recently
from
181fbd2
to
930e911
Compare
bastelfreak
changed the title
bastelfreak
previously approved these changes
Jun 28, 2023
bastelfreak
reviewed
Jun 28, 2023
SimonHoenscheid
force-pushed
the
initdb_parameters
branch
from
f8a933c
to
ed0fbf8
Compare
bastelfreak
approved these changes
Jun 28, 2023
postgresql::server::instance::initdb define: * auth_host * auth_local * lc_messages * username postgresql::server::initdb class: * auth_host * auth_local * lc_messages * username postgresql::server class: * auth_host * auth_local * lc_messages * username refactoring postgresql::server::instance::initdb define: * unnecessary conditions * remove brackets from if conditions * parameter checking and initdb command concatination
SimonHoenscheid
force-pushed
the
initdb_parameters
branch
from
ed0fbf8
to
7d5b118
Compare
SimonHoenscheid
requested review from
a team,
alexjfisher,
deric,
ekohl and
smortex
as code owners
bastelfreak
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
postgresql::server::instance::initdb define:
postgresql::server::initdb class:
postgresql::server class:
refactoring
postgresql::server::instance::initdb define:
Additional Context
Add any additional context about the problem here.
Related Issues (if any)
Mention any related issues or pull requests.
Checklist
puppet apply)