Fix NOREPLICATION option for Postgres 9.1

[brandonwamboldt]

Fixing a bug when using this module with Postgresql 9.1 that causes alter role statements to execute during every apply.

If replication is disabled, the module is supposed to alter the role to set NOREPLICATION, however, $replication_sql is set to an empty string by default to avoid breaking on pre 9.1 installs.

[kbarber-jenkins2]

Can one of the admins verify this patch?

[teajaymars]

This is a similar-but-different solution to my pull request #334

However I think they both have the exact same effect, mine is a bit cleaner though. (?)

[brandonwamboldt]

@Zephod I tried that first, but it breaks Postgres versions under 9.1. On line 34 that query uses the contents of $replication_sql to create a user, and the NOREPLICATION option won't be recognized on older versions of Postgres causing it to fail.

That's why I did my more hacky solution :)

[teajaymars]

Got it. I'll close mine.

So to confirm, this stops it spitting out crap on stdout every single time right?

[brandonwamboldt]

@Zephod Yes sir, it was annoying me having that crap on stdout and was causing my nodes to show as changed in the puppet dashboard. My patch fixes it :)

[jhoblitt]

I can confirm that this patch does work for me with psql 9.1.11. (As a side note, this PR doesn't break the tests... they were broken by new rspec-puppet releases, I opened #339 investigating the test failures.)

[brandonwamboldt]

I really hope a dev comes around and merges this, it's an annoying bug :(

[apenney]

I will definitely take a look at this for you all in an hour or so. Let me drink this coffee first as I just crawled out of bed.