Fix data directory handling #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change introduced in b781849 added a complex operation that was not handled correctly for all operating systems. This fix includes the following corrections: - Change the systemd config and reload systemd for datadir changes in RHEL 7, and move configuration for this into postgresql::server::config since it is managing both the PGDATA and PGPORT variables - Make sure Debian systems stop the service before changing the datadir - Recreate cert links after running initdb in Debian and early ubuntu - Change the port in the port spec to avoid selinux issues - Turn off selinux in pgdata spec to avoid selinux issues - Correct syntax for describing presence of a directory in pgdata spec - Move the pgdata spec to the end of the tests so that puppet doesn't have to manager purging and recreating the original datadir - Update README to describe all caveats of using this parameter
underscorgan
pushed a commit
that referenced
this pull request
Oct 31, 2014
Fix data directory handling
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Oct 23, 2017
Fix data directory handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change introduced in b781849 added
a complex operation that was not handled correctly for all operating
systems. This fix includes the following corrections:
RHEL 7, and move configuration for this into
postgresql::server::config since it is managing both the PGDATA and
PGPORT variables
have to manager purging and recreating the original datadir