Fix/encoding #540
Fix/encoding #540
Conversation
mcanevet
force-pushed
the
fix/encoding
branch
from
4a61319
to
bdca79e
Compare
|
nice! |
|
What's the rationale for putting this in postgresql::server::initdb instead of, say, postgresql::server::config? Any why make it an elsif with $needs_initdb? Wouldn't there be a case where $needs_initdb was true and also the encoding needed to be fixed? |
mcanevet
force-pushed
the
fix/encoding
branch
2 times, most recently
from
36fe438
to
f7f0c74
Compare
|
Discussed at puppet contributors summit, lgtm. Will just wait on TravisCI. |
|
@cmurphy travis fails for 2.7, which imo can be ignored >_> |
|
@cmurphy could you please merge this if it's OK for you also? |
|
@mcanevet the travis errors can be fixed by rebasing against master, where we pinned rspec-core to fix the issue on puppet 2.7/ruby 1.8.7. @igalic I disagree with ignoring 2.7 errors. We plan to remove support for puppet 2.7 on the next naturally occurring major release, but while we still officially support it we need to keep CI green on it. |
mcanevet
force-pushed
the
fix/encoding
branch
from
f7f0c74
to
e1034d9
Compare
|
@cmurphy Travis still fails, but because of this : puppetlabs/puppetlabs-concat#270 this time... |
|
Ignoring the strict variables failures for now. Thanks! |
No description provided.