Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-661) Add host parameter to psql commands #568

Merged
merged 1 commit into from
Mar 3, 2015
Merged

(MODULES-661) Add host parameter to psql commands #568

merged 1 commit into from
Mar 3, 2015

Conversation

petems
Copy link
Contributor

@petems petems commented Mar 3, 2015

This allows you to use postgres_pqsl commands to be run against a specified host. The ultimate goal being that you can use puppetlabs-postsgresql to run against remote instances, especially things such as Amazons RDS service.

This PR will be further extended to do things like allow remote table_grant and the like.

This allows you to use `postgres_pqsl` commands to be run against a specified host. The ultimate goal being that you can use `puppetlabs-postsgresql` to run against remote instances, especially things such as Amazons RDS service.

This PR will be further extended to do things like allow remote `table_grant` and the like.
underscorgan pushed a commit that referenced this pull request Mar 3, 2015
(MODULES-661) Add host parameter to psql commands
@underscorgan underscorgan merged commit 8b49b58 into puppetlabs:master Mar 3, 2015
@underscorgan
Copy link
Contributor

👍 thanks @petems

@petems petems deleted the MODULES-661-remote_postgres branch March 4, 2015 11:50
@ColinHebert
Copy link

Unless I'm mistaken, this still assumes that there is a user (defined with :psql_user) on the machine with passwordless access to the database.

@petems
Copy link
Contributor Author

petems commented Mar 6, 2015

@ColinHebert Yes, right now it was a very MVP implementation, I'm breaking up the larger "Use the postgres module to fully provision a remote instance" into smaller chunks.

@tomhey's done some awesome work around adding a new connection_options hash using Postgres Environment variables (http://www.postgresql.org/docs/current/static/libpq-envars.html) which makes this a lot better, and is probably the best approach to properly implement it. Discussion's here if you're interested https://tickets.puppetlabs.com/browse/MODULES-661

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants