Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.2.0 prep #576

Merged
merged 1 commit into from
Mar 9, 2015
Merged

4.2.0 prep #576

merged 1 commit into from
Mar 9, 2015

Conversation

underscorgan
Copy link
Contributor

No description provided.

cyberious added a commit that referenced this pull request Mar 9, 2015
@cyberious cyberious merged commit 62a774a into puppetlabs:4.2.x Mar 9, 2015
@underscorgan underscorgan deleted the 4.2.0-prep branch March 9, 2015 20:47
@tomhey
Copy link

tomhey commented Mar 9, 2015

The "Add host parameter to postgresql_psql type (MODULES-661)" ticket is still under active discussion, I'd like to get this release to include the stable API change. Rather than adding a new parameter that may very well be deprecated in the next release.

What sort of timescale are you looking at/ expecting for the 4.2.0 release?

(Maybe slightly controversially, if we don't have time to complete the API discussion for MODULE-661 then I'd prefer it's commit to be reverted and skipped for this release)

@underscorgan
Copy link
Contributor Author

@tomhey the release is going out tomorrow.

@underscorgan
Copy link
Contributor Author

^^ @petems could you give a 👍 👎 for including host in a release going out tomorrow, since you implemented that?

@petems
Copy link
Contributor

petems commented Mar 9, 2015

I'm ok with it being yanked, with the view to it being eventually re-implemented using the connection_hash @tomhey mentioned, saves having something that would be quickly deprecated.

👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants