(MODULES-1834) Be less strict when changing template1 encoding #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently use: UTF8 != UTF-8 We should instead use: pg_char_to_encoding(UTF8) == pg_char_to_encoding(UTF-8)
|
👍 from me! |
|
cool! |
| @@ -94,7 +94,7 @@ | |||
| SET encoding = pg_char_to_encoding('${encoding}'), datistemplate = TRUE | |||
| WHERE datname = 'template1'", | |||
| unless => "SELECT datname FROM pg_database WHERE | |||
| datname = 'template1' AND pg_encoding_to_char(encoding) = '${encoding}'", | |||
| datname = 'template1' AND encoding = pg_char_to_encoding('${encoding}')", | |||
There was a problem hiding this comment.
i'm guessing that postgresql already normalises encoding, which is why you're not passing both of those to the function, as per your comment/commit message, i.e.:
datname = 'template1' AND pg_encoding_to_char(encoding) = pg_char_to_encoding('${encoding}')There was a problem hiding this comment.
encoding is an integer here. No need to normalize it.
Example:
postgres=# SELECT encoding from pg_database;
encoding
----------
6
6
6
6
6
6
6
underscorgan
pushed a commit
that referenced
this pull request
Mar 12, 2015
(MODULES-1834) Be less strict when changing template1 encoding
|
Thanks @sathieu ! |
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Oct 23, 2017
(MODULES-1834) Be less strict when changing template1 encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently use: UTF8 != UTF-8
We should instead use: pg_char_to_encoding(UTF8) == pg_char_to_encoding(UTF-8)