Replication type #580
Merged
Replication type #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the work, this needs a little bit of cleanup, Could you add some documentation then make sure the tests pass and squash your commits. |
|
@tphoney I fixed the tests & squashed the commits. The existing types for this module are not documented in README.md. They'll get their doc in the types tab on the forge anyway. |
| @@ -0,0 +1,9 @@ | |||
| Puppet::Type.newtype(:postgresql_replication_slot) do | |||
| ensurable | |||
There was a problem hiding this comment.
Could you add an @doc description, similar to https://github.com/puppetlabs/puppetlabs-mysql/blob/master/lib/puppet/type/mysql_user.rb#L3 (well, more verbose than that would be great).
|
@hunner done |
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Oct 23, 2017
Replication type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a type to setup replication slots on a Postgresql master server.