postgresql::server::extension needs to have defaults for postgresql_psql

[rvstaveren]

Using same pattern as with postgresql::server::database.
observed when installing the pg_trgm using pgsql 9.4 for puppetdb

affects: puppetlabs-postgresql 4.2.0

code used:

class { 'postgresql::globals':
manage_package_repo => true,
version => $postgres_version,
}->
class { 'postgresql::server':
listen_addresses => '*',
}->
class { '::puppetdb::database::postgresql':
manage_server => false,
database_name => $database_name,
database_username => $database_username,
database_password => $database_password,
before => [Class['puppetdb::server'],
Class['puppetdb::server::validate_db']],
}

class { 'postgresql::server::contrib':
}->
postgresql::server::extension { 'pg_trgm':
database => $database_name,
}

class { '::puppetdb::server':
listen_address => '0.0.0.0',
listen_port => '8080',
ssl_listen_address => '0.0.0.0',
ssl_listen_port => '8081',
open_ssl_listen_port => true,
database => 'postgres',
}

[igalic]

that.. makes sense.
do you know of other places where we're missing out on setting these defaults?

[hunner]

Could you fix the indentation to 2 spaces?

[rvstaveren]

@igalic it looks like manifests/server/initdb.pp uses postgresql_psql, but doesn't have a Postgresql_psql setting any defaults. I could do the same over there, as with the extension, but the question is whether a postgresql::server class is active too at the same time

[igalic]

this almost sounds like it's a call for… ACCEPTANCE TESTS!

[rvstaveren]

Can't imagine that changes spaces in 6d937f0 broke the build :(

[igalic]

Failures:

1) postgresql::server service_ensure => running should set postgres password
Failure/Error: is_expected.to contain_exec('set_postgres_postgrespw').with({
expected that the catalogue would contain Exec[set_postgres_postgrespw] with unless set to "/usr/bin/psql -h localhost -c 'select 1' > /dev/null" but it is set to "/usr/bin/psql -h localhost -p 5432 -c 'select 1' > /dev/null"
# ./spec/unit/classes/server_spec.rb:42:in `block (3 levels) in <top (required)>'

2) Puppet::Type::Postgresql_psql::ProviderRuby with port string executes with the given port
Failure/Error: provider.run_sql_command("SELECT something")
Postgresql_psql[rspec psql test](provider=ruby) received :run_command with unexpected arguments
expected: (["psql", "-p", "5555", "-t", "-c", "SELECT something"], "postgres", "postgres")
got: (["psql", "-p", "5555", "-t", "-c", "\"SELECT something\""], "postgres", "postgres")
# ./lib/puppet/provider/postgresql_psql/ruby.rb:21:in `block in run_sql_command'
# ./lib/puppet/provider/postgresql_psql/ruby.rb:20:in `chdir'
# ./lib/puppet/provider/postgresql_psql/ruby.rb:20:in `run_sql_command'
# ./spec/unit/puppet/provider/postgresql_psql/ruby_spec.rb:79:in `block (3 levels) in <top (required)>'

these are the failures as reported by travis

[igalic]

you might have to rebase, post #584

[rvstaveren]

@igalic thx for the pointer! btw, do you want to have the manifests/server/initdb.pp case addressed too in the same pull request?

[igalic]

if it's not too much effort for you: sure!
but please change the commit messages and the title to say you're addressing a general case.

also, once done you may wanna clean up these commits by squashing them down to a single one (or… few:)

[igalic]

i just noticed your rebase is actually a merge commit, please take a look at this