(MODULES-2181) Fix variable scope for systemd-override #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbarber
force-pushed
the
maint/4.4.x/fix_systemd_override_for_manage_package_repo
branch
from
bee45a5
to
d931c1f
Compare
|
For reference, before & after this patch: https://gist.github.com/kbarber/f61a654f7cc9b74714e2 |
kbarber
force-pushed
the
maint/4.4.x/fix_systemd_override_for_manage_package_repo
branch
2 times, most recently
from
bbf89ad
to
7f11a56
Compare
$manage_package_repo wasn't in scope for the template systemd-override.erb This was causing all RHEL7 systems with manage_package_repo on to fail on startup using systemctl, as the proper path to the original service file is set incorrectly. This patch adds the manage_package_repo to the top of the ::config class, and adds some basic tests in config_spec.rb to ensure we don't regress on this. Signed-off-by: Ken Barber <ken@bob.sh>
kbarber
force-pushed
the
maint/4.4.x/fix_systemd_override_for_manage_package_repo
branch
from
7f11a56
to
c21e2e5
Compare
kbarber
changed the title
DavidS
added a commit
that referenced
this pull request
Jul 1, 2015
…_for_manage_package_repo (MODULES-2181) Fix variable scope for systemd-override
|
Travis CI got confused here. I tested it locally against puppet 4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$manage_package_repo wasn't in scope. This was causing all RHEL7 systems with
manage_package_repo on to fail on startup using systemctl, since the template
systemd-override.erb relies on that variable in a conditional, to ensure the
correct PGDG path is set.
Signed-off-by: Ken Barber ken@bob.sh