4.7.1 Release Prep #743
Merged
4.7.1 Release Prep #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
postgres db user password change failing when postgres is listening on non standard port number.
Prior to this commit, when creating databases with a name or owner that has characters which must be quoted (e.g., "pe-postgres"), the postgresql::server::database define fails due to a SQL syntax error.
(MODULES-3024) Quote database objects when creating databases
postgresql_escape returned an invalid string if the password end in '$':
postgres=# alter role "postgres" password $$foo$$$;
ERROR: syntax error at or near "$"
LINE 1: alter role "postgres" password $$foo$$$;
…scape Escape case where password ends with '$'.
Fix quoting
Fix password change failing
Add postgresql_version fact
Allow puppetlabs-concat 2.x
4.7.x mergeback to master
Fix markdown error in README
The `$service_provider` variable in params.pp is user-definable via `postgresql::globals::service_provider`. Thus params.pp should reference that variable correctly, like other variables from globals.pp.
The cause turned out to be a misconfigured setting for OS type Archlinux.
Correctly set $service_provider
On current amazon linux ami (details below), and open puppet (details below), the postgres module (installed as part of puppetlabs/puppetdb) currently, tries to start postgressql server with /etc/init.d/postgresql9.4 , while the init script doesn't have the dot in the version number, so it needs to use /etc/init.d/postgresql94 From what I see in all available postgresql server rpms, currently on amazon linux ami, seems all the init scripts of postgresql doesn't have a dot in the suffix version number. Supporting info: [root@puppet ~]# yum list postgres* | grep 'server\.'; postgresql94-server.x86_64 9.4.5-1.63.amzn1 @amzn-updates postgresql8-server.x86_64 8.4.20-4.51.amzn1 amzn-updates postgresql92-server.x86_64 9.2.14-1.56.amzn1 amzn-updates postgresql93-server.x86_64 9.3.10-1.60.amzn1 amzn-updates for i in postgresql8-server.x86_64 postgresql92-server.x86_64 postgresql93-server.x86_64 postgresql94-server.x86_64; do echo $i; repoquery -l $i | grep init.d; done postgresql8-server.x86_64 /etc/rc.d/init.d/postgresql postgresql92-server.x86_64 /etc/rc.d/init.d/postgresql92 postgresql93-server.x86_64 /etc/rc.d/init.d/postgresql93 postgresql94-server.x86_64 [root@puppet ~]# puppet --version 4.3.2 [root@puppet ~]# rpm -qa | grep puppet | grep server puppetserver-2.2.1-1.el6.noarch [root@puppet ~]# [root@puppet ~]# cat /etc/os-release NAME="Amazon Linux AMI" VERSION="2015.09" ID="amzn" ID_LIKE="rhel fedora" VERSION_ID="2015.09" PRETTY_NAME="Amazon Linux AMI 2015.09" ANSI_COLOR="0;33" CPE_NAME="cpe:/o:amazon:linux:2015.09:ga" HOME_URL="http://aws.amazon.com/amazon-linux-ami/" [root@puppet ~]# [root@puppet ~]# cat /etc/system-release Amazon Linux AMI release 2015.09
postgres server init script naming on amazon linux ami
correcting formatting error in README
…workaround amazon linux defaults to postgresql92 now
Archlinux service reload parameter is incorrect.
This moves all copyright statements to the NOTICE file in accordance with the ASFs guidelines on applying the Apache-2.0 license.
(FM-4046) Update to current msync configs [006831f]
…ql_version_fact Revert "Add postgresql_version fact"
Add missing onlyif_function to sequence grant code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a rebase from master.