Don't overwrite or calculate the environment twice #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
| end | ||
|
|
||
| private | ||
|
|
||
| def get_environment | ||
| environment = resource[:connect_settings] || {} | ||
| environment = resource[:connect_settings].dup || {} |
There was a problem hiding this comment.
This doesn't work when resource[:connect_settings] is empty. I guess environment = environment.dup on the next line is better, but I'll verify that when I have a test environment set up.
janfabry
force-pushed
the
MODULES-3311-environment-duplication
branch
from
9413304
to
47ab296
Compare
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Oct 23, 2017
…ent-duplication Don't overwrite or calculate the environment twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#688 passed the
environmentparameter, but did not notice that it was already calculated. And we should duplicate theconnect_settings, otherwise we add to it.Fixes https://tickets.puppetlabs.com/browse/MODULES-3311