Allow username and password as integers #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution @sathieu! Can you fix the acceptance tests failures? It appears that the service is not listening on the port after the change. |
sathieu
force-pushed
the
nonstring_password
branch
from
7a743b9
to
a3d2717
Compare
|
The test fail for another reason: Nothing to do with my PR. |
|
@sathieu I believe that error was fixed in master by pinning json_pure if ruby < 2.0. Can you rebase from master and push again? Sorry! |
Fixes: String can't be coerced into Fixnum
sathieu
force-pushed
the
nonstring_password
branch
from
a3d2717
to
53c67fe
Compare
|
@bmjen. Done. CI in progress. |
|
Thanks @sathieu . The unit test failures on puppet 4 are a known issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: String can't be coerced into Fixnum