Allow working directory to be configurable via globals (instead of always using /tmp) #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
note selector doesn't include inline equals expression due to puppet 3
|
Opened ticket MODULES-3759 |
|
thanks for the PR! please add the new param to the readme and add some tests. |
|
I updated the documentation and added a couple tests. Let me know if you want tests that cover every class or define where the the attribute is used. |
|
merging. out of curiosity, is there a reason psql needs to be run in a particular dir? does the dir need to be writable? |
|
@eputnam - I was having problems on a server with /tmp mounted in /etc/fstab with noexec option. There is a security check in the scap security guide that calls for that. I don't recall exactly which part of module was breaking but when I google'd error message it brought me to the release notes for the change that made psql use /tmp to begin with. |
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Oct 23, 2017
Allow working directory to be configurable via globals (instead of always using /tmp)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running on a server with /tmp mounted with "noexec" option in fstab (to satisfy security) I was getting an error like:
Error: Error executing SQL; psql returned 256: 'could not change directory to "/root"
which was resolved for most people back in version 2.2.1 by setting /tmp as the working directory for psql. I need to set the folder to something else now that /tmp is secure so this pull request makes /tmp configurable.
This pull also has a commit from another pull request I have open that is waiting for 4.6.1 to come out so the tests will pass.