(MODULES-4682) Pass default_connect_settings to validate service #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eputnam
requested changes
May 23, 2017
manifests/server/service.pp
Outdated
| @@ -33,6 +34,7 @@ | |||
| run_as => $user, | |||
| database_name => $default_database, | |||
| database_port => $port, | |||
| connect_settings => $connect_settings, | |||
There was a problem hiding this comment.
@vinzent , looks like the linter is complaining about the hash rocket alignment in this resource. please make sure they all line up.
|
@eputnam rebased and updated |
eputnam
approved these changes
Jul 26, 2017
|
gah, now a rebase and it should be good @vinzent |
If using CentOS or RedHat Enterprise Linux with PostgreSQL from
SoftwareCollections the validation of the service fails because
it needs the `LD_LIBRARY_PATH` environment variable to work properly.
To pass the env for example for postgresql_psql one can only set
```
class {'postgresql::globals':
default_connect_settings => {
'LD_LIBRARY_PATH' => '/opt/rh/rh-postgresql95/root/usr/lib64',
}
```
This patch passes the default_connect_settings to the
`validate_db_connection` resource in `postgresql::service`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If using CentOS or RedHat Enterprise Linux with PostgreSQL from
SoftwareCollections the validation of the service fails because
it needs the
LD_LIBRARY_PATHenvironment variable to work properly.To pass the env for example for postgresql_psql one can only set
This patch passes the default_connect_settings to the
validate_db_connectionresource inpostgresql::service