[MODULES-4598] Revert "Revert "fix default params for SUSE family OSes"" #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wilson208 @eputnam |
|
@mmoll I'm going to run this through our CI again and try to see what was up. |
eputnam
requested changes
Apr 14, 2017
manifests/globals.pp
Outdated
| @@ -111,10 +111,10 @@ | |||
| 'Suse' => $::operatingsystem ? { | |||
| 'SLES' => $::operatingsystemrelease ? { | |||
| /11\.[0-4]/ => '91', | |||
| default => '93', | |||
| default => '94', | |||
There was a problem hiding this comment.
@mmoll turns out we need a separate condition. SLES 12.0 needs to stay at 93 but SLES >=12.2 works with 94.
There was a problem hiding this comment.
I see.. I'll whip something up
|
I checked on the 12SP1 DVD that SP1 already has postgresql94, the second commit should fix that |
eputnam
approved these changes
Apr 14, 2017
|
thanks @mmoll ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 63ad343, which reverted
commit b6fbbb3.