Let listen_addresses be defined independently #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hunner
added a commit
that referenced
this pull request
May 25, 2017
Postgresql module is often extended by other shared modules. Shared modules should not use resource-like class definitions to let the callers use them when necessary. It is still a reasonable behaviour for the shared module to set max_connections. Making it optional would allow this to happen. Removing the default value "localhost" should not break anything as it is already the default of PostgreSQL and on every distribution I know of.
|
Of note, if the |
|
Of note, if the listen_address is not configured at all then postgresql will only create a unix socket. If it is present, it will create a tcp socket as well. That makes this change backwards-incompatible.
I don't think so. It is defaulted to "localhost" when not set.
|
cegeka-jenkins
pushed a commit
to cegeka/puppet-postgresql
that referenced
this pull request
Feb 3, 2022
Postgresql module is often extended by other shared modules. Shared modules should not use resource-like class definitions to let the callers use them when necessary. It is still a reasonable behaviour for the shared module to set max_connections. Making it optional would allow this to happen. Removing the default value "localhost" should not break anything as it is already the default of PostgreSQL and on every distribution I know of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgresql module is often extended by other shared modules. Shared modules should not use resource-like class definitions to let the callers use them when necessary. It is still a reasonable behaviour for the shared module to set max_connections. Making it optional would allow this to happen.
Removing the default value "localhost" should not break anything as it is already the default of PostgreSQL and on every distribution I know of.