(WIP) add psql task #929
Closed
(WIP) add psql task #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spacepants can you look at #930 I had this ready for puppet conf but didnt get to release it. Is there anything i am missing ? |
|
Oh cool, beaker-task_helper cleans up a lot of this. From the travis logs, it's bombing out because it's not finding bolt at I'll see if I can replicate the issue. |
|
@spacepants so i fixed up beaker-task_helper bolt installs successfully. Still no dice. I will hopefully get to look tomorrow, any ideas are welcome |
|
Apologies @spacepants, i have been AFK for a few weeks. #930 Is merged. Is there anything i missed. Thanks for the work ! |
|
@spacepants Is there any movement on this PR? |
|
Sorry, yeah this was accomplished with #930. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a task to execute arbitrary SQL via psql using a Ruby script and open3.
I've stubbed out tests based on examples from other Puppetlabs modules, but if there's a preferred testing method, I'm more than happy to refactor. Thanks!