Rubocop Process Complete #953
Conversation
| end | ||
|
|
||
| describe port(55433) do | ||
| describe port(55_433) do |
There was a problem hiding this comment.
Is this port number correct?
There was a problem hiding this comment.
Rubocop states that Numeric Literals should be separated into lengths of no more than 3 digit's each, with underscores in the place of decimals.
There was a problem hiding this comment.
I would suggest changing it back and disabling the rule for this line.
|
|
||
| it 'should not run some SQL when the onlyif query returns no rows' do | ||
| pp = <<-EOS | ||
| pp_seven = <<-MANIFEST.unindent |
There was a problem hiding this comment.
Do we need to use .unindent anymore?
According to https://zaiste.net/posts/heredoc_in_ruby/ it will 'remove blank characters up to the column where heredoc starts'. I cannot see any blank characters.
There was a problem hiding this comment.
From what I understand it is to unindent the heredoc to the point were at least one line of it has no indents.
There was a problem hiding this comment.
That or the first line.
There was a problem hiding this comment.
This is due to certain heredocs failing when applied if there are excess indents
Rubocop Process Complete
No description provided.