(MODULES-3588) Update documentation for change in MODULES-3399 #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| ~~~ | ||
|
|
||
| The `exec['test']` resource will always fail because the exit code from the the external file `C:\fail.ps1` is `1`. This behavior may have unintended consequences if you are combining mulitple external files. |
The behavior about $LASTEXITCODE was modified in MODULES-3399 however there was no documentation to demonstrate the change. This commit modifies the README with the new behavior and example code. [ci skip]
glennsarti
force-pushed
the
ticket/master/MODULES-3588-doc-script-exit-codes
branch
from
f25defd
to
67c8419
Compare
|
I think we might want to clarify a bit more / add further detail in a subsequent iteration, but this is probably fine for now. (For instance, it might help to talk about the difference between cmdlets and external executables / the call operator - and how cmdlets don't have a I'm going to merge and docs review can take another pass to make sure its clear enough. |
|
Changed branch to stable, so that this can be merged up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior about $LASTEXITCODE was modified in MODULES-3399 however there
was no documentation to demonstrate the change. This PR modifies the README
with the new behavior and example code.
[ci skip]