Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(SUP-2736) Documentation #170

Merged
merged 2 commits into from
Oct 10, 2022
Merged

(SUP-2736) Documentation #170

merged 2 commits into from
Oct 10, 2022

Conversation

MartyEwings
Copy link
Contributor

No description provided.

@MartyEwings MartyEwings added the enhancement New feature or request label Oct 10, 2022
@MartyEwings MartyEwings requested a review from a team as a code owner October 10, 2022 11:10
elainemccloskey
elainemccloskey suggested changes Oct 10, 2022
View reviewed changes
Copy link
Contributor

@elainemccloskey elainemccloskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the params from postgres.pp and vmware.pp as you can't configure them here and they are documented in system.pp where they are pulled from.

@MartyEwings
Copy link
Contributor Author

@elainemccloskey should be complete

@elainemccloskey elainemccloskey merged commit dc421dc into puppetlabs:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elainemccloskey elainemccloskey elainemccloskey approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartyEwings @elainemccloskey