Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FreeBSD support #342

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Fix FreeBSD support #342

merged 4 commits into from
Jan 31, 2024

Conversation

smortex
Copy link
Collaborator

@smortex smortex commented Feb 8, 2022

While the code has some code related to FreeBSD, the module is not functional on this platform.

This PR fix the FreeBSD support and allows using this module on this OS.

@smortex smortex requested a review from a team as a code owner February 8, 2022 02:33
@puppet-community-rangefinder
Copy link

puppetdb::params is a class

that may have no external impact to Forge modules.

This module is declared in 33 of 578 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

$etcdir = '/etc/puppetdb'
$vardir = '/var/db/puppetdb'
$database_embedded_path = "${vardir}/db/db"
$puppet_confdir = pick($settings::confdir,'/etc/puppet')
$puppet_service_name = 'puppetmasterd'
}
'FreeBSD': {
$puppetdb_package = inline_epp('puppetdb<%= $puppetdb::params::puppetdb_major_version %>')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice hack 👍

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2023

CLA assistant check
All committers have signed the CLA.

@bastelfreak
Copy link
Collaborator

@smortex can you please rebase?

The FreeBSD ports install PuppetDB configuration in
/usr/local/etc/puppetdb.
The OpenBSD path is kept unchanged but I suspect this is not the actual
directory on this platform.
FreeBSD ships with all current versions of puppet and make packages
available with the major version as part of the package name, e.g.
puppet7, puppetserver8, puppetdb7, puppetdb-terminus8.

Gather the major from the user specified version if available, or
default to the latest version if not specified to build actual package
names.
@smortex
Copy link
Collaborator Author

smortex commented Jan 31, 2024

Rebased and adjusted to remove references to Puppet 6 and add those for Puppet 8.

@bastelfreak bastelfreak merged commit ecec68d into puppetlabs:main Jan 31, 2024
4 checks passed
@smortex smortex deleted the fix-freebsd branch January 31, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants