Skip to content

Commit

Permalink
(maint) Remove symlink check in Travis CI
Browse files Browse the repository at this point in the history
Previously Travis CI was emitting false negative failures for the symlink
check.  This was due to a gem having symlinks in it, and Travis bundles gems
into ./vendor which the rake task should ignore. Until this is is fixed in
https://tickets.puppetlabs.com/browse/PDK-1199 this commit removes the symlink
check from Travis as Appveyor already does this test.
  • Loading branch information
glennsarti committed Oct 12, 2018
1 parent e7e6bea commit 37e5828
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
9 changes: 9 additions & 0 deletions .sync.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,5 +35,14 @@ appveyor.yml:
.gitlab-ci.yml:
delete: true

# Due to https://tickets.puppetlabs.com/browse/PDK-1199 we need to stop the symlink checks in Travis CI
# The symlink checks are still done in Appveyor so there's no loss in coverage
.travis.yml:
includes:
- env: CHECK="syntax lint metadata_lint check:git_ignore check:dot_underscore check:test_file rubocop"
- env: CHECK=parallel_spec
- env: PUPPET_GEM_VERSION="~> 4.0" CHECK=parallel_spec
rvm: 2.1.9

spec/default_facts.yml:
unmanaged: true
3 changes: 2 additions & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ env:
matrix:
fast_finish: true
include:
# PDK Update doesn't replace this line, but instead adds a new one.
-
env: CHECK="syntax lint metadata_lint check:symlinks check:git_ignore check:dot_underscore check:test_file rubocop"
env: CHECK="syntax lint metadata_lint check:git_ignore check:dot_underscore check:test_file rubocop"
-
env: CHECK=parallel_spec
-
Expand Down

0 comments on commit 37e5828

Please sign in to comment.