(MODULES-2207) Modulesync #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| gem 'puppet-lint', :require => false | ||
| gem 'puppetlabs_spec_helper', :require => false | ||
| gem 'puppet_facts', :require => false | ||
| gem 'mocha', '~>0.10.5', :require => false |
There was a problem hiding this comment.
@cyberious can you review these changes?
I have pulled out
- nokogiri
- mime-types
- simplecov
- yard
- pry
- rspec-puppet
There was a problem hiding this comment.
Added back in simplecov and yard. May need to add back in rspec-puppet as well.
ferventcoder
changed the title
|
This is likely to fail on v4 - it did with Travis CI |
|
@cyberious This is probably going to be an effort - do you have any quick ideas into why it fails on future parser/ v4.0? |
|
Determining that the effort here for fixing the failures will be addressed with a new ticket. |
ferventcoder
changed the title
|
Rebased with fixes from #122 |
This brings the following items under modulesync: * .gitignore * .travis.yml * Gemfile * appveyor.yml * spec/spec.opts More importantly, this ensures that acl has up to date Gemfile, Travis CI and AppVeyor configurations that allow it to be tested properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the following items under modulesync:
More importantly, this ensures that acl has up to date Gemfile, Travis
CI and AppVeyor configurations that allow it to be tested properly.