(MODULES-2245) Fixes issue with assumption of strings #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,7 +36,9 @@ | |||
| ){ | |||
| sqlserver_validate_instance_name($instance) | |||
| validate_re($config_name,'^\w+') | |||
| validate_re($value,'^\d+$', "Value for ${config_name}, for instance ${instance}, must be a integer value, you provided ${value}") | |||
| if !is_integer($value) { | |||
There was a problem hiding this comment.
validate_re always requires a string, so instead we are now using the is_integer method from stdlib and validating this way to avoid casting it to a string just to check if it is an integer
- Puppet < 4 casts numbers to string, now they remain numeric this is to hand that case for next release of Puppet Enterprise
|
Minor nit with commit - |
ferventcoder
changed the title
|
Second nit with commit - need an empty line between summary and message. |
|
fixed commit messages |
|
please push :) |
|
We can't even pass lint for our licensing!! |
|
We need to add the lint bits in there. Perhaps as another issue . |
ferventcoder
added a commit
that referenced
this pull request
Jul 16, 2015
(MODULES-2245) Fixes issue with assumption of strings
|
Darn it, meant to fix up the commit message prior to that merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to handle that case for next release of Puppet Enterprise