(MODULES-2464) Simplify query for sp_configure check #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Git commit nitpick - I don't really feel I get a good explanation of what changed in the commit message. Would you mind explaining it better why you no longer need the section of code that was removed? |
ferventcoder
changed the title
|
You also have specs to fix up. |
- Due to the success of table creation and insertion the query executes successfully even though when ran through SSMS it properly throws the error. Fallout from ruby refactor
cyberious
changed the title
|
@ferventcoder updated and passing |
ferventcoder
added a commit
that referenced
this pull request
Sep 2, 2015
(MODULES-2464) Simplify query for sp_configure check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
did not properly flag the error.