(MAINT) Correct supported versions & platforms #244
Conversation
| @@ -32,10 +32,10 @@ Microsoft SQL Server is a database platform for Windows. The sqlserver module le | |||
|
|
|||
| The sqlserver module requires the following: | |||
|
|
|||
| * Puppet Enterprise 3.7 or later. | |||
There was a problem hiding this comment.
It requires Puppet Agent 4.7.0 or later
There was a problem hiding this comment.
Ahh, a leftover mistake from the existing README. On it!
There was a problem hiding this comment.
It doesn't look like other modules actually mention this bit at all... probably because it's already in metadata.json / shown prominently on the forge (and when changing compat, adds another spot in the codebase where one might miss making the change)?
https://github.com/puppetlabs/puppetlabs-powershell#requirements
https://github.com/puppetlabs/puppetlabs-acl#setup
https://github.com/puppetlabs/puppetlabs-dsc#windows-system-prerequisites
https://github.com/puppetlabs/puppetlabs-apache#setup
https://github.com/puppetlabs/puppetlabs-stdlib#setup
https://github.com/puppetlabs/puppetlabs-iis#setup
I'm OK with scrapping the line altogether...
There was a problem hiding this comment.
Oh 2nd thought. Yup agreed.
There was a problem hiding this comment.
Line removed and commit message corrected.
This commit removes the specification of minimum required Puppet Enterprise version from the Setup Requirements section of the readme. It does so both because this information already exists in the metadata.json and because the forge prominently displays compatible versions. This commit also adds Windows Server 2016 as a supported option in the same section of the readme since this is also specified in the metadata.json file.
Iristyle
deleted the
maint/master/correct-readme-minimum-supported-version
branch
This commit corrects the minimum supported version of Puppet Enterprise
from
3.7to4.7.0in the Setup Requirements section of the readme.It also adds Windows Server 2016 as a supported option in the same
section of the readme.