Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(MAINT) Correct supported versions & platforms #244

Merged
merged 1 commit into from Oct 20, 2017
Merged

(MAINT) Correct supported versions & platforms #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 1 addition & 2 deletions README.md
View file
Open in desktop
Expand Up @@ -32,10 +32,9 @@ Microsoft SQL Server is a database platform for Windows. The sqlserver module le

The sqlserver module requires the following:

* Puppet Enterprise 3.7 or later.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It requires Puppet Agent 4.7.0 or later

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, a leftover mistake from the existing README. On it!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@Iristyle Iristyle Oct 20, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't look like other modules actually mention this bit at all... probably because it's already in metadata.json / shown prominently on the forge (and when changing compat, adds another spot in the codebase where one might miss making the change)?

https://github.com/puppetlabs/puppetlabs-powershell#requirements
https://github.com/puppetlabs/puppetlabs-acl#setup
https://github.com/puppetlabs/puppetlabs-dsc#windows-system-prerequisites
https://github.com/puppetlabs/puppetlabs-apache#setup
https://github.com/puppetlabs/puppetlabs-stdlib#setup
https://github.com/puppetlabs/puppetlabs-iis#setup

I'm OK with scrapping the line altogether...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh 2nd thought. Yup agreed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line removed and commit message corrected.

* .NET 3.5. (Installed automatically if not present. This might require an internet connection.)
* The contents of the SQL Server ISO file, mounted or extracted either locally or on a network share.
* Windows Server 2012 or 2012 R2.
* Windows Server 2012, 2012 R2, or 2016.

### Beginning with sqlserver

Expand Down