Add wildcard & bypass Intermediate Store support #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurbarton
changed the title
bastelfreak
reviewed
Oct 6, 2018
manifests/init.pp
Outdated
| @@ -74,11 +74,17 @@ | |||
| String[1] $root_store = 'LocalMachine', | |||
| String[1] $store_dir = 'My', | |||
| Stdlib::Windowspath $scripts_dir = 'C:\temp', | |||
| Boolean $exportable = true | |||
| Boolean $exportable = true, | |||
| Optional[Boolean] $wildcard = false, | |||
There was a problem hiding this comment.
Does Optional[] make sense here? It's preferred to always initiate a Boolean with true or false and not allowing undef.
|
Good point - I've pushed a change, setting defaults to false (no change to current behavior) |
|
Thanks @arthurbarton ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
wildcard
There are some other pending PRs that implement this in much the same way.
Setting this to true will add "MachineKeySet" to the key_storage_flags
This has only been tested where the certificate is also a wildcard
interstore
Setting this to true will store intermediate certs bundled into the chain in the target store_dir
There is a new test that just sets all the optional flags to true.
Now that #66 is merged, the invoked templates do not need to be removed each run.