(MODULES-5589) - add user/group to war file

[lmayorga1980]

add new parameters to support ownership on the war file.

[lmayorga1980]

@adrienthebo , It seems like the README update broke the build but that was just a README change 😕

[pmcmaw]

Would it be possible to copy a similar format and move the Default value onto a new line.
There are some examples in the README but it would look like something similar to the following:

The 'owner' of the tomcat war file.  

Default value: 'tomcat'.

[lmayorga1980]

just sent an update and waiting for travis to complete.

[pmcmaw]

The same as the above comment for 'user'.

[pmcmaw]

@lmayorga1980 I re-kicked Travis, seems it was a transient error and is now passing. 👍

[lmayorga1980]

@pmcmaw looks good now?

[pmcmaw]

@lmayorga1980 So the unit tests need updated to include your new parameters.
If you add the new parameters you have implemented into the following test:

    let :params do
      {
        :catalina_base  => '/opt/apache-tomcat/test',
        :app_base       => 'webapps2',
        :war_ensure     => 'present',
        :war_name       => 'sample2.war',
        :war_source     => '/tmp/sample.war',
        :allow_insecure => true,
      }
    end
    it { is_expected.to contain_archive('tomcat::war sample.war').with(
      'source'         => '/tmp/sample.war',
      'path'           => '/opt/apache-tomcat/test/webapps2/sample2.war',
      'allow_insecure' => true,
    )
    }

This test can be found in the following location: 'spec/defines/war_spec.rb'.

[lmayorga1980]

Missed that one. Going to push later today on this one.

[lmayorga1980]

@pmcmaw added the requested test. 👍

[pmcmaw]

@lmayorga1980 I have created the following PR #254 with your changes and a few minor doc updates. I would like to thank you for your patience and contribution, it is much appreciated. 👍