Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(MODULES-5589) - add user/group to war file #254

Merged
merged 2 commits into from Sep 12, 2017

Conversation

pmcmaw
Copy link
Contributor

@pmcmaw pmcmaw commented Sep 12, 2017

This includes #253 with a few minor docs changes.

@tphoney tphoney merged commit c02b892 into puppetlabs:master Sep 12, 2017
@alexjfisher
Copy link

Are you sure this actually works?

The user and group parameters of archive only seem to apply when extract => true
https://github.com/voxpupuli/puppet-archive/blob/bf4d097377c0a4f933533d0d87b03f62fac32a92/lib/puppet/type/archive.rb#L215-L221

@alexjfisher
Copy link

See voxpupuli/puppet-archive#22

@alexjfisher
Copy link

#265 has been opened as part of puppethack and should fix this.

@pmcmaw
Copy link
Contributor Author

pmcmaw commented Dec 7, 2017

Hey @alexjfisher, thanks for the comments and apologies that the fix did not work.
#265 Has been merged and hopefully this resolves your issue 👍

@alexjfisher
Copy link

@pmcmaw No worries. The puppet-archive parameter names are pretty misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants