Implemented multiple remotes feature for git provider. #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting. What's the use-case for this? |
|
It was documented as a supported feature in the README, however was never implemented. |
| vcsrepo { "/path/to/repo": | ||
| ensure => present, | ||
| provider => git, | ||
| source => {"origin" => "https://github.com/puppetlabs/puppetlabs-vcsrepo.git", "other_remote" => "https://github.com/other_user/puppetlabs-vcsrepo.git"}, |
There was a problem hiding this comment.
Could you put this one multiple lines?
source => {
"origin" => "https://github.com/puppetlabs/puppetlabs-vcsrepo.git",
"other_remote" => "https://github.com/other_user/puppetlabs-vcsrepo.git",
},
|
Could you put the ticket number in the commit? Like "(MODULES-####) " |
| source => {"origin" => "https://github.com/puppetlabs/puppetlabs-vcsrepo.git", "other_remote" => "https://github.com/other_user/puppetlabs-vcsrepo.git"}, | ||
| } | ||
|
|
||
| It is important to note that you must specify a mapping for the remote that is specified in the 'remote' property - this is set to 'origin' by default. |
There was a problem hiding this comment.
@laurenrother Could I get 3 minutes of your time on this?
jonnytdevops
force-pushed
the
multiple_remotes
branch
from
95d5f87
to
5d6ef98
Compare
|
This will conflict with #221, so one of them should land first and then the other can be rebased / updated. |
|
Sounds good, thanks! |
| ##### Using multiple remotes with a repository | ||
| Instead of specifying a single string in the 'source' property, you can specify a hash with multiple name => URL mappings, | ||
|
|
||
| vcsrepo { "/path/to/repo": |
There was a problem hiding this comment.
This should be wrapped in a puppet... block
hunner
added a commit
that referenced
this pull request
Jan 22, 2015
Implemented multiple remotes feature for git provider.
|
Merging this one first, as #221 is currently in need of a rebase anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows multiple remotes to be used by specifying a hash of name => URL mappings in the source property, instead of just a single URL string.