Add Settings::Container#reset!, set up inheritance relationship #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to test classes that use settings without persisting state beyond those tests we need a way to wipe all settings for that container; this commit adds a #reset! method to do just that.
When a class with settings is subclassed, the settings applicable to the superclass are generally applicable to the subclass. In order to link up the super/subclass relationship, this commit uses the Class#inherited hook to manually create a settings instance in the subclass that pulls settings from the superclass.
This was referenced Feb 24, 2015
|
Tested and happy with it. 👍 |
adrienthebo
added a commit
that referenced
this pull request
Feb 28, 2015
…ner-inheritance Add Settings::Container#reset!, set up inheritance relationship
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to add a rugged based Git implementation we need to subclass R10K::Git::Cache, which relies on having settings applied to the subclass. This adds adding some cleanup functionality for the tests for those examples, and reconfigures the settings mixin to properly handle inheritance of settings values.