Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update commander requirement from >= 4.4.3, < 4.6.0 to >= 4.4.3, < 4.7.0 #140

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 12, 2021

Updates the requirements on commander to permit the latest version.

Changelog

Sourced from commander's changelog.

=== 4.6.0 / 2021-04-09

  • Fix error with SortedSet on Ruby 3.0 (#98).
  • Remove #reset_io as it didn't do anything.
  • Drop support for Ruby < 2.4.

=== 4.5.2 / 2020-03-12

  • Fix bug handling global options provided in option=value form (#47). (@​orien)
  • Fix ERB warnings under Ruby 2.7. (@​esotericpig)
  • Fix bug handling global options placed before command name (#32). (@​orien)

=== 4.5.1 / 2020-03-08

  • Fix bug causing global options to be ignored when arguments are present (#86). (@​orien)

=== 4.5.0 / 2020-01-21

  • Drop support for Ruby < 2.3.
  • Fix bug parsing double dash (#75).

=== 4.4.7 / 2018-10-22

=== 4.4.6 / 2018-07-31

  • Fix unexpected internal behavior change introduced in 4.4.5.

=== 4.4.5 / 2018-05-22

=== 4.4.4 / 2018-01-18

=== 4.4.3 / 2016-12-28

  • Fix deprecated constant warnings on Ruby 2.4.

=== 4.4.2 / 2016-12-20

  • Add help_paging program flag so that help paging may be disabled. (@​gogiel)

=== 4.4.1 / 2016-12-02

  • Fix #36 - Warning about MissingSourceFile (@​fallwith)
  • Fix build on Ruby 1.9

... (truncated)

Commits
  • 40d06bf Version 4.6.0
  • 203dae3 Update rubocop, drop support for Ruby < 2.4
  • 8c5b75f Rescue Ruby 3 errors for SortedSet
  • 4969096 Remove dependencies for Ruby < 2
  • 4dbce3d Add ruby 3 to Travis
  • 83c255e Merge pull request #95 from orien/help-after-command-argument
  • ea4d912 Use --help after command and argument
  • b8abd42 Version 4.5.2
  • 4b40d83 Merge pull request #90 from orien/global-option-equals
  • 2a7b07b Remove global options provided in the option=value form
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested review from briancain, highb and a team as code owners April 12, 2021 13:01
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 12, 2021
@dependabot dependabot bot force-pushed the dependabot/bundler/commander-gte-4.4.3-and-lt-4.7.0 branch from f025d6f to bcd08fc Compare July 13, 2021 17:02
@highb
Copy link
Contributor

highb commented Jul 13, 2021

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 13, 2021

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

Copy link
Contributor

@highb highb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream changes to commander 4.6.0 look mostly like rubocop updates so I think this is safe. 👍 Others feel free to merge if you agree. 😄

Copy link
Contributor

@genebean genebean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me

@genebean genebean closed this Jul 16, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 16, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@genebean genebean reopened this Jul 16, 2021
@genebean
Copy link
Contributor

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 16, 2021

Looks like this PR is already up-to-date with master! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@genebean genebean merged commit f2f3a3b into master Jul 16, 2021
@genebean genebean deleted the dependabot/bundler/commander-gte-4.4.3-and-lt-4.7.0 branch July 16, 2021 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants