Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change gettext INSTALL_MODE and REMOVE_MODE variables in PPM. #591

Closed
mavrothal opened this issue Oct 5, 2015 · 4 comments
Closed

Change gettext INSTALL_MODE and REMOVE_MODE variables in PPM. #591

mavrothal opened this issue Oct 5, 2015 · 4 comments

Comments

@mavrothal
Copy link
Contributor

pkg_chooser.sh passes the gettext $INSTALL_MODE and $REMOVE_MODE variables to installmodes.sh and removemodes.sh. However, if the translation of the variables in the 3 different scripts is not identical to the spacing, punctuation and capitalisation, PPM will fail.
Would be better if the gtkdialog INSTALL_MODE and REMOVE_MODE variables are interpreted within pkg_chooser.sh and non-translatable variables are passed to installmodes.sh and removemodes.sh scripts to facilitate translation.
Alternatively, some big fat comment should be placed in the script to alert translators of the fact that translation of the variables should be identical across the 3 scripts.

@mavrothal
Copy link
Contributor Author

Currently, option 2 is implemented in b5df298

@mavrothal
Copy link
Contributor Author

After L18L's suggestion put the scripts under the same text domain to "enforce" a common translation. see d1c59c0

@dimkr
Copy link
Contributor

dimkr commented Oct 7, 2015

@mavrothal, let me know if you want me to spin fresh Librepup images for testing.

@mavrothal
Copy link
Contributor Author

In spite the very annoying behaviour of some, this is nothing major that needs rushing out.
PPM works in english fine both with and without this change.
Several translations have been done successfully already with the previous version (xanad actually brought this issue to my attention during such a translation) so there is not any real issue if the translator is a bit careful. And I'm sure after all this commotion will be.
Now, if you need just one more change to justify a new spin, this one sure qualifies ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants