Make buildah and podman work in jammy64 (fixes #3042, #3043) #3044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g static-nodes-permissions.conf too
dimkr
commented
Apr 21, 2022
| *) continue ;; | ||
| esac | ||
| [ -z "$F7" ] && continue #precaution | ||
| # mknod: /dev/net/tun: No such file or directory | ||
| [ ! -d ${F2%/*} ] && mkdir -p -m $F3 ${F2%/*} |
There was a problem hiding this comment.
Huge bug in this line. If /dev/net/tun is missing and needs to be 666, but /dev/net is missing, the latter should be 755 and not 666. Otherwise, spot can't ls /dev/net and /dev/net/tun is inaccessible.
01micko
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various development tools run containers, and it's good to have stuff like https://github.com/89luca89/distrobox working on Puppy.
apt install -y podman && run-as-spot podman run --rm -it alpine:3.15works:This is not perfect, some things are still broken or spit errors/warnings. But this PR fixes 80% of the big problems, with minimum changes.Should work wellEDIT: one thing is still problematic, for some reason /dev/net is 600 and spot can't access /dev/net/tun