-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unneeded escaping of - (fixes #3379) #3397
Drop unneeded escaping of - (fixes #3379) #3397
Conversation
@@ -66,14 +66,14 @@ DB_OTHERS="`ls -1 ${PREPATH}Packages-* | grep -v "$DB_MAIN"`" | |||
#120903 improve pkg db selection... | |||
case $DB_MAIN in | |||
*"-puppy-2-"*|*"-puppy-3-"*|*"-puppy-4-"*|*"-puppy-5-"*) DB_OTHERS="" ;; | |||
*) DB_OTHERS="`echo "$DB_OTHERS" | grep -v '\\-puppy\\-[2345]\\-'`" ;; #do not look in puppy-2, puppy-3, puppy-4 or puppy-5. | |||
*) DB_OTHERS="`echo "$DB_OTHERS" | grep -v '\-puppy-[2345]-'`" ;; #do not look in puppy-2, puppy-3, puppy-4 or puppy-5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha, this one never worked in first place!
~$ (echo abcd; echo a-puppy-4-) | grep -v '\\-puppy\\-[2345]\\-'
abcd
a-puppy-4-
~$ (echo abcd; echo a-puppy-4-) | grep -v '\-puppy-[2345]-'
abcd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SO, by the rationale in these changes, only a leading -
needs escaping in a grep
call.. yes?
Yes - either escape the first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@peabee I'm waiting for you to confirm that this solves your problem. You're probably the only one running woof-CE on Slackware current. |
Its not easy to test until it has been merged into testing branch............?? I guess I have to download Woof-CE from https://github.com/dimkr/woof-CE/tree/bugfix/more-grep-warnings |
Just done manual edits of 0setup and 1download and they seemed OK - no grep warnings. |
It wasn't easy to fix either 😠 |
I'll be building on -current soon enough too. My wayland -current install even prints! 😲 I reckon merge this. In fact Ill do it now, deal with consequences, if any, later. |
Test build: Still get a warning during 3builddistro:
|
OK after a lot of digging looks like its: |
Alternative to #3395 that should work.