Also handle aliases provided by compat, like string-split

purcell · Nov 13, 2023 · 8eb052b · 8eb052b
1 parent 5f2ae2d
commit 8eb052b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/package-lint-test.el b/package-lint-test.el
@@ -459,17 +459,20 @@ Alternatively, depend on (emacs \"24.3\") or greater, in which cl-lib is bundled
 (ert-deftest package-lint-test-error-new-compat-functions ()
   (should
    (equal
-    '((6 1 error "You should depend on (emacs \"27.1\") or the compat package if you need `proper-list-p'."))
+    '((6 1 error "You should depend on (emacs \"27.1\") or the compat package if you need `proper-list-p'.")
+      (7 1 error "You should depend on (emacs \"29.1\") or the compat package if you need `string-split'."))
     (package-lint-test--run
-     "(proper-list-p '(foo))"))))
+     "(proper-list-p '(foo))
+\(string-split s)"))))
 
 (ert-deftest package-lint-test-accepts-new-functions-with-compat ()
   (should
    (equal
     '()
     (package-lint-test--run
      ";; Package-Requires: ((compat \"29\"))
-\(proper-list-p '(foo))"))))
+\(proper-list-p '(foo))
+\(string-split s)"))))
 
 (ert-deftest package-lint-test-error-new-compat-macros ()
   (should

diff --git a/package-lint.el b/package-lint.el
@@ -182,15 +182,15 @@ symbol such as `variable-added'.")
           (insert-file-contents el-path)
           (goto-char (point-min))
           (while (search-forward-regexp (rx line-start
-                                            "(compat-" (group (or "defun" "defmacro" "defvar"))
+                                            "(compat-" (group (or "defun" "defmacro" "defvar" "defalias"))
                                             (+ space)
                                             symbol-start
                                             (group (+? any))
                                             symbol-end)
                                         nil t)
             (pcase (match-string 1)
               ("defvar" (push (intern (match-string 2)) symbols))
-              ((or "defun" "defmacro") (push (intern (match-string 2)) functions)))))))
+              ((or "defun" "defmacro" "defalias") (push (intern (match-string 2)) functions)))))))
     (cons symbols functions))
   "A cons cell of (VARS . FUNCTIONS) supported by \"compat\".")