✨ Add port selection to set_variable and read_variable
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs hardware testing |
|
Also was thinking we should probably clean up the error message for specifying a port that doesn't exist. Its the same error when specifying a port for other v5 functions such as |
yeah that would be best |
omegaStag
approved these changes
Jan 24, 2023
ayushuk
changed the title
set_variable and read_variableset_variable and read_variable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added optional port argument to the
set_variableandread_variablefunctions.New usage:
pros v5 set_variable [OPTIONS] VARIABLE VALUE [PORT]pros v5 read_variable [OPTIONS] VARIABLE [PORT]Motivation:
As described in #258 this is a quality of life improvement to allow the user to specify a destination port when using
set_variableandread_variable. It allows users with multiple brains plugged in to be able to specify the target brain.References (optional):
Closes #258
Test Plan:
pros v5 set_variableand specify a port with no brain plugged in (the command should error out)pros v5 set_variableand specify no port with no brain plugged in ("No v5 ports were found!" message should show)pros v5 set_variableand specify no port with a brain plugged in (command should run normally on the default port)pros v5 set_variableand specify a port with a brain plugged in (command should run normally on the specified port)pros v5 read_variableand specify a port with no brain plugged in (the command should error out)pros v5 read_variableand specify no port with no brain plugged in ("No v5 ports were found!" message should show)pros v5 read_variableand specify no port with a brain plugged in (command should run normally on the default port)pros v5 read_variableand specify a port with a brain plugged in (command should run normally on the specified port)Testing screenshots:
