Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Adding and removing depots #299

Merged
merged 10 commits into from
Oct 4, 2023
Merged

Conversation

mayankpatibandla
Copy link
Contributor

Summary:

Added new conductor commands to add, remove, and query depots.

Motivation:

Implements #275

References (optional):

#275

Test Plan:

Added arms depot and tested that it got added to conductor.pros. Also tested remove and query.

  • Added test depot
  • Removed test depot
  • Queried depots

@mayankpatibandla mayankpatibandla added the feature A brand new feature label Oct 2, 2023
@mayankpatibandla mayankpatibandla self-assigned this Oct 2, 2023
@mayankpatibandla mayankpatibandla linked an issue Oct 2, 2023 that may be closed by this pull request
@ayushuk ayushuk added the branchline This issue is part of branchline development label Oct 3, 2023
@ayushuk
Copy link
Member

ayushuk commented Oct 3, 2023

Can you add testing screenshots or videos of using this?

@mayankpatibandla
Copy link
Contributor Author

image

@noam987
Copy link
Contributor

noam987 commented Oct 3, 2023

That test doesn't seem correct. that link is not a depot, feel free to try with this one
https://pros.cs.purdue.edu/v5/_static/beta/testing-mainline.json
I would make sure you call pros c query-templates before and after each new command.
I would also try to apply a template from a newly added depot

@mayankpatibandla mayankpatibandla changed the title ✨Feature/adding removing depots ✨Adding and removing depots Oct 4, 2023
@ayushuk ayushuk merged commit 4daf497 into develop Oct 4, 2023
10 checks passed
@ayushuk ayushuk deleted the feature/adding-removing-depots branch October 4, 2023 23:43
This was referenced Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branchline This issue is part of branchline development feature A brand new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding/removing depots
4 participants