Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Add rich click #307

Merged
merged 5 commits into from
Jan 14, 2024
Merged

✨Add rich click #307

merged 5 commits into from
Jan 14, 2024

Conversation

mayankpatibandla
Copy link
Contributor

Summary:

Adds rich click

Motivation:

Create better formatting for the CLI commands

Test Plan:

  • Windows
  • Linux (SSH)
  • M2 Mac
  • Intel Mac

@mayankpatibandla mayankpatibandla self-assigned this Dec 6, 2023
requirements.txt Outdated Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
requirements.txt Show resolved Hide resolved
@ayushuk
Copy link
Member

ayushuk commented Dec 23, 2023

I was experimenting one last time and it seems some of the help text is missing and for some reason hidden commands are shown on mac. (commands like build-compile-commands are marked hidden)

Screenshot 2023-12-22 at 8 44 57 PM

All I did was switch to the branch, pip install -r "requirements.txt" and ran pros.

@ayushuk
Copy link
Member

ayushuk commented Dec 23, 2023

For some reason this isn't an issue on my Ubuntu machine and both have the same version of click (8.1.7).

Expected behavior:
Screenshot 2023-12-22 at 8 54 19 PM

@mayankpatibandla
Copy link
Contributor Author

Works fine on Windows 10, click 8.1.7. No idea what could cause this discrepancy.
image

@ayushuk
Copy link
Member

ayushuk commented Dec 23, 2023

I'll investigate this more when I get the chance tomorrow. Probably something small and it could be related to my specific setup.

Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue was related to my setup. Works for me on MacOS, if I'm not wrong then I think we've tested pretty much everywhere now so we should be good to merge.

@ayushuk ayushuk merged commit 25ea823 into develop Jan 14, 2024
10 checks passed
@ayushuk ayushuk deleted the rich-click-2 branch January 14, 2024 16:44
@ayushuk ayushuk restored the rich-click-2 branch January 19, 2024 00:59
@ayushuk ayushuk deleted the rich-click-2 branch January 19, 2024 01:22
@ayushuk ayushuk mentioned this pull request Jan 19, 2024
This was referenced Jan 23, 2024
@mayankpatibandla mayankpatibandla mentioned this pull request Feb 16, 2024
8 tasks
@mayankpatibandla mayankpatibandla mentioned this pull request Apr 1, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants