Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add command to reset conductor.pros #320

Merged
merged 7 commits into from
Feb 12, 2024
Merged

✨ Add command to reset conductor.pros #320

merged 7 commits into from
Feb 12, 2024

Conversation

mayankpatibandla
Copy link
Contributor

@mayankpatibandla mayankpatibandla commented Jan 26, 2024

Summary:

Adds a command to reset conductor.pros

Motivation:

There are some issues with applying templates that get resolved by resetting conductor.pros so a command is added to facilitate this.

References (optional):

Test Plan:

  • Run pros c reset
  • Check if conductor.pros is deleted
  • conductor.pros should be regenerated next time pros c is run

@mayankpatibandla mayankpatibandla changed the title Add command to reset conductor.pros ✨ Add command to reset conductor.pros Jan 26, 2024
@mayankpatibandla mayankpatibandla self-assigned this Jan 26, 2024
Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushuk
Copy link
Member

ayushuk commented Jan 31, 2024

@BennyBot One of the technicalities of this PR is that if someone is offline and they reset conductor they wont be able to make a project again until they connect to the internet again. Maybe we can add a warning as a heads up since it could result in irreversible deletion of conductor.pros which isn't reverseable until they connect to the internet again.

pros/cli/conductor.py Outdated Show resolved Hide resolved
Co-authored-by: BennyBot <48661356+BennyBot@users.noreply.github.com>
Copy link
Member

@ayushuk ayushuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayushuk ayushuk merged commit 18fb090 into develop Feb 12, 2024
10 checks passed
@ayushuk ayushuk deleted the reset-conductor branch February 12, 2024 17:14
@ayushuk ayushuk mentioned this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants